Re: Merits
  By: Pascal Schmidt to John H. Guillory on Sun May 02 2004 05:34 pm

 >  JHG> "break" out of a loop, or "GOTO" a label, etc.
 > You can, no doubt on that. However, sometimes a break or goto can be much
 > clearer in the end.
 > 
 > Consider:
 > 
 >     FILE *fp;
 >     int res;
 > 
 >     fp = fopen("foo", "w");
 >     res = write(fp, ...); /* some data */
 >     if (res = -1) {
 >         fclose(fp);
 >         return -1;
 >     }
 >     res = write(fp, ...); /* some other data */
 >     fclose(fp);
 >     return res;
FILE *fp;
int res;

    fp = fopen("foo","w");
    if (fp != NULL) {
       res = write(fp, ...);
       if (res != -1) {
         res = write(fp, ...);
       }
     }
     fclose(fp);

is more along the lines of how to do it, though in the above, it looks
more like your wanting to do C++ try/catch statements... The above lines
of code can be made easier to read via making macros out of them, and yet
they still maintain their simplicity.
      
 > and:
 > 
 >     FILE *fp;
 >     int res;
 > 
 >     fp = fopen("foo", "w");
 >     res = write(fp, ...);
 >     if (res == -1)
 >         goto out;
 >     res = write(fp, ...);
 > out:
 >     fclose(fp);
 >     return res;
 > 
 > The latter keeps the cleanup code (in this case only one fclose, but there
 > could be several lines of cleanup code) in one place and not duplicated at e
 > possible exit point.

And what's wrong with:

void CleanUp(FILE *fp) {
     fclose(fp);
}

and adding 1 line that reads CleanUp(fp);  after closing if?

--- SBBSecho 2.00-Win32