Hi Nhan,
NT> Just found a little gem in one of our code...

NT> #include 
NT> #include 
NT> #include 

NT> int main()
NT> {
NT>  int offset, len = 8;
NT>  const char str[] = "hello, world";

NT>  offset = (len - strlen(str)) / 2;
                   ^
  NEVER, EVER, do subtraction with an unsigned !  strlen() returns size_t,
which is always unsigned.  Also, since size_t is often unsigned long, len
will get promoted to unsigned long & wraparound ensues.

NT>  offset = max(0, offset);
              ^^^
  Where is max() defined?  If it's a macro, at least the programmer was
sensible enough to (attempt to) evaluate offset outside the macro & avoid
the ugliness of double evaluation.

NT>  printf("%d\n", offset);
NT>  return (0);
NT> }

NT> The programmer expected offset to be 0 in this case, but it isn't...
  The moral of the story: do your arithmetic with the proper type.

Michael Stapleton of Graphic Bits.

___I'm only here for the taglines.

--- Blue Wave/RA v0.7 Q-Blue