Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

2 new defect(s) introduced to Synchronet found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 514629:  API usage errors  (PW.PRINTF_ARG_MISMATCH)
/tmp/sbbs-Nov-10-2024/src/smblib/smblib.c: 298 in ()


________________________________________________________________________________________________________
*** CID 514629:  API usage errors  (PW.PRINTF_ARG_MISMATCH)
/tmp/sbbs-Nov-10-2024/src/smblib/smblib.c: 298 in ()
292     		else
293     			if(time(NULL)-start>=(time_t)smb->retry_time)
294     				break;
295     		++count;
296     		SLEEP((count / 10) * smb->retry_delay);
297     	}
>>>     CID 514629:  API usage errors  (PW.PRINTF_ARG_MISMATCH)
>>>     argument is incompatible with corresponding format string conversion (expected type "int" but argument has type "long")
298     	safe_snprintf(smb->last_error,sizeof(smb->last_error),"%s timeout locking message base after %d seconds", __FUNCTION__, time(NULL) - start);
299     	return(SMB_ERR_TIMEOUT);
300     }
301
302     /****************************************************************************/
303     /* Read the SMB header from the header file and place into smb.status		*/

** CID 514628:  API usage errors  (PRINTF_ARGS)


________________________________________________________________________________________________________
*** CID 514628:  API usage errors  (PRINTF_ARGS)
/tmp/sbbs-Nov-10-2024/src/smblib/smblib.c: 298 in smb_locksmbhdr()
292     		else
293     			if(time(NULL)-start>=(time_t)smb->retry_time)
294     				break;
295     		++count;
296     		SLEEP((count / 10) * smb->retry_delay);
297     	}
>>>     CID 514628:  API usage errors  (PRINTF_ARGS)
>>>     Argument "time(NULL) - start" to format specifier "%d" was expected to have type "int" but has type "long".
298     	safe_snprintf(smb->last_error,sizeof(smb->last_error),"%s timeout locking message base after %d seconds", __FUNCTION__, time(NULL) - start);
299     	return(SMB_ERR_TIMEOUT);
300     }
301
302     /****************************************************************************/
303     /* Read the SMB header from the header file and place into smb.status		*/


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4gdQbQRNsarCbK0jIoVQSWT2zCPijRqaed4AhLiEI9Z7MR9SJQ09ot5XPbn9SW-2F14-3D04SY_7FYjIqE8olEh4k02KWtt1r1LGSyuXVEtCuKuJCXgAQbRNqpwvGc4zcZ5uKeIndhuSqNnxi4ZbqnqhqxxcEUjkJJHGyGkBZt6V7UXUX2xnB2lvPBmqBCBxBghPzBYV7kJY89l3F0Je2EKuh7lbcH1Ki5248pEoplbC6UdQ14IH1AzZ-2BYu06Kjq-2F-2BS7xugvit0MheMfmyl63WZ-2BGQqWv04fA-3D-3D


--- SBBSecho 3.21-Linux