Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 514519:    (LOCK)
/main.cpp: 4849 in sbbs_t::daily_maint()()
/main.cpp: 4849 in sbbs_t::daily_maint()()


________________________________________________________________________________________________________
*** CID 514519:    (LOCK)
/main.cpp: 4849 in sbbs_t::daily_maint()()
4843     		lprintf(result ? LOG_ERR : LOG_INFO, "Daily event: '%s' returned %d", cmd, result);
4844     	}
4845     	if((sys_status & SS_NEW_MONTH) && cfg.sys_monthly[0]) {
4846     		lputs(LOG_INFO, "DAILY: Running monthly event");
4847     		const char* cmd = cmdstr(cfg.sys_monthly,nulstr,nulstr,NULL);
4848     		online = ON_LOCAL;
>>>     CID 514519:    (LOCK)
>>>     "external" unlocks "this->input_thread_mutex" while it is unlocked.
4849     		int result = external(cmd, EX_OFFLINE);
4850     		online = false;
4851     		lprintf(result ? LOG_ERR : LOG_INFO, "Monthly event: '%s' returned %d", cmd, result);
4852     	}
4853     	lputs(LOG_INFO, "DAILY: System maintenance ended");
4854     	sys_status&=~SS_DAILY;
/main.cpp: 4849 in sbbs_t::daily_maint()()
4843     		lprintf(result ? LOG_ERR : LOG_INFO, "Daily event: '%s' returned %d", cmd, result);
4844     	}
4845     	if((sys_status & SS_NEW_MONTH) && cfg.sys_monthly[0]) {
4846     		lputs(LOG_INFO, "DAILY: Running monthly event");
4847     		const char* cmd = cmdstr(cfg.sys_monthly,nulstr,nulstr,NULL);
4848     		online = ON_LOCAL;
>>>     CID 514519:    (LOCK)
>>>     "external" locks "this->input_thread_mutex" while it is locked.
4849     		int result = external(cmd, EX_OFFLINE);
4850     		online = false;
4851     		lprintf(result ? LOG_ERR : LOG_INFO, "Monthly event: '%s' returned %d", cmd, result);
4852     	}
4853     	lputs(LOG_INFO, "DAILY: System maintenance ended");
4854     	sys_status&=~SS_DAILY;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4gdQbQRNsarCbK0jIoVQSWT2zCPijRqaed4AhLiEI9Z7MR9SJQ09ot5XPbn9SW-2F14-3DmVJv_7FYjIqE8olEh4k02KWtt1r1LGSyuXVEtCuKuJCXgAQZYt7Pe-2B8KlpNPxf3vYfbGXTetKrkOysaWsLoXwVVJy-2BlT3vWHLSa-2F-2BgpVoMRk-2FB9lZhpdNOATgKKch-2FKRWKdw7CGPsa8-2BoRGvrYP8DjPqUmQVJXsmXD2xm4gPlAPoQOpnW8tWCZcdj7lp745Fp7QOqFvNAcU4EQLHiapc9wQpj6A-3D-3D


--- SBBSecho 3.21-Linux