Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

2 new defect(s) introduced to Synchronet found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 514483:  API usage errors  (PRINTF_ARGS)


________________________________________________________________________________________________________
*** CID 514483:  API usage errors  (PRINTF_ARGS)
/websrvr.c: 1659 in http_logon()
1653     		SAFECOPY(session->user.modem, session->client.protocol);
1654     		SAFECOPY(session->user.comp, session->host_name);
1655     		SAFECOPY(session->user.ipaddr, session->host_ip);
1656     		session->user.logontime = (time32_t)session->logon_time;
1657     		int result = putuserdat(&scfg, &session->user);
1658     		if(result != 0)
>>>     CID 514483:  API usage errors  (PRINTF_ARGS)
>>>     No argument for format specifier "%d".
1659     			lprintf(LOG_ERR, "%04d %s [%s]  !Error %d writing user data for user #%d"
1660     				,session->socket, session->client.protocol, session->host_ip
1661     				,session->username, session->user.number);
1662
1663     	}
1664     	SAFECOPY(session->client.user, session->username);

** CID 514482:  API usage errors  (PW.TOO_FEW_PRINTF_ARGS)
/websrvr.c: 1661 in ()


________________________________________________________________________________________________________
*** CID 514482:  API usage errors  (PW.TOO_FEW_PRINTF_ARGS)
/websrvr.c: 1661 in ()
1655     		SAFECOPY(session->user.ipaddr, session->host_ip);
1656     		session->user.logontime = (time32_t)session->logon_time;
1657     		int result = putuserdat(&scfg, &session->user);
1658     		if(result != 0)
1659     			lprintf(LOG_ERR, "%04d %s [%s]  !Error %d writing user data for user #%d"
1660     				,session->socket, session->client.protocol, session->host_ip
>>>     CID 514482:  API usage errors  (PW.TOO_FEW_PRINTF_ARGS)
>>>     the format string requires additional arguments
1661     				,session->username, session->user.number);
1662
1663     	}
1664     	SAFECOPY(session->client.user, session->username);
1665     	session->client.usernum = session->user.number;
1666     	client_on(session->socket, &session->client, /* update existing client record? */true);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4gdQbQRNsarCbK0jIoVQSWT2zCPijRqaed4AhLiEI9Z7MR9SJQ09ot5XPbn9SW-2F14-3DjGNe_7FYjIqE8olEh4k02KWtt1r1LGSyuXVEtCuKuJCXgAQZrw1ACipL81Cfrev1KTkNSpg9ocZGsXxFU4AldvxV89V-2FFS8Im4F3ZlIWKiU1IgZ7U6FnHvW5nOIPElnOgDye48Et-2FcrMwNOZVyWRSzqRdvKvjv7tIxk-2BD72e1fmIEEOvn4SDov1pv-2FzEWSevpHegP3dEU8oXtKIA8RNAEjZ1XUg-3D-3D


--- SBBSecho 3.21-Linux