Hello Wilfred!

Nov 16 11:38 2013, Wilfred van Velzen wrote to Markus Reschke:

 MR>> ...
 MR>>         if ((!echo->keepAllSeen) &&
(echo->useAka->zone !=
 MR>> pktOrigAddr.zone)) seenByCount = 0;

 WvV> You don't need the extra () pairs here. The precedence rules for the 
 WvV> operators are very clear about that.

 WvV> But maybe it's a style choice, and lets not get into that! ;)

It's my style :-) I like to make the code easy to read and add tons of
comments about how something works or is done. Thats very helpful for
maintaining the code. Unfortunately there aren't much comments in husky.

I'm also looking into some issues regarding the area/filefix. If a link
hasn't got any read or write access for an echo the areafix will list the
echo marked with "R" for read-only. I've wrote a fix for that
(areafix shows a "-" for no access at all) and have to test it.
Another problem is the access level control. It works for tossing/scanning
but not for the areafix. If a link requests an echolist the areafix sends a
list also containing echos the link don't got any write/read access to
(link's access level too low). We could discuss if that is nice or bad, but
the link can subscribe those echos. WTF! The way it should be is that a
link should get an error message if he's trying to subscribe an echo
without the required access level. BTW, the echolist seems to include
access related details only for linked echos. It would be much better if
the echolist would state access limitation for all echos, not just the
linked ones.

... a lot to fix :-)

Regards,
Markus

---