G'Day John,
 
-=> Quoting John Gardeniers to Frank Adam <=-
It did get here after all, but took it's time.

 JG> All constructive criticism, sugestions  and comments are
 JG> welcome. Insults are best kept to yourself.
Ok :)

 JG> #define MAXPATH 160 /* Gives it plenty of room */
Dos allows 67 chars plus the filename so yes, you're a wasteful person,
 but i'll keep it to myself :)
                           
 JG> if(argc>3)
 JG> mode=atoi(argv[3]); /* 0 = Copy, 1 = Move, 2 = Rename */
Maybe an "if(mode  2) user_idiot();" after the
previous line 
would speed up things on error here, there is no reason to go any further 
into the program if it is TRUE.
Unless i missed it default to something somewhere else ?  

This is only esthetics, but lately i've been putting most of my error messgs 
in a separate function under a switch, and #define all possible errors.
Looks nice that way, and not any harder to follow, of course the defines are 
meaningful.
On error i just call errs(erno) or warns(warno).
On fatals i even stick an exit(int) in there, makes returning various 
errorlevels to batches an easy task.
Just thought i'll share that one :-)

 JG> /* Convert source & destination to upper case */
 JG> for(cnt=0; cnt src[cnt]=toupper(src[cnt]);

 JG> for(cnt=0; cnt dst[cnt]=toupper(dst[cnt]);
Hmm, strlen() in a loop is not very efficient, try this:

char *ptr1 = dst;
while(*ptr1 != '\0') *ptr1++ = toupper(*ptr1);
and the same for src.

 JG> {
 JG> puts("File cannot be copied to itself!\n");
I would do this check at the validate_dest routine, and abort from there..


  L8r Frank (fadam{at}ozemail.com.au).
                   
___ Blue Wave/DOS v2.21

--- Maximus 3.01