Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

3 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 331349:  Uninitialized variables  (MISSING_RETURN)
/tmp/sbbs-May-02-2021/src/conio/bitmap_con.c: 446 in color_value()


________________________________________________________________________________________________________
*** CID 331349:  Uninitialized variables  (MISSING_RETURN)
/tmp/sbbs-May-02-2021/src/conio/bitmap_con.c: 446 in color_value()
440     {
441     	if (col & 0x80000000)
442     		return col;
443     	if (col < sizeof(palette) / sizeof(palette[0]))
444     		return (0xff << 24) | (palette[col].red << 16) | (palette[col].green << 8) | palette[col].blue;
445     	fprintf(stderr, "Invalid colour value: %08x\n", col);
>>>     CID 331349:  Uninitialized variables  (MISSING_RETURN)
>>>     Arriving at the end of a function without returning a value.
446     }
447
448     static struct rectlist *get_full_rectangle_locked(struct bitmap_screen *screen)
449     {
450     	size_t i;
451     	struct rectlist *rect;

** CID 319807:  Memory - illegal accesses  (UNINIT)
/tmp/sbbs-May-02-2021/3rdp/src/mozjs/js-1.8.5/js/src/configure: 9243 in main()


________________________________________________________________________________________________________
*** CID 319807:  Memory - illegal accesses  (UNINIT)
/tmp/sbbs-May-02-2021/3rdp/src/mozjs/js-1.8.5/js/src/configure: 9243 in main()
9237       cat > conftest.$ac_ext <>>     CID 319807:  Memory - illegal accesses  (UNINIT)
>>>     Using uninitialized value "res" when calling "uname".
9243                 (void)uname(res);  if (res != 0) { domain = res->domainname; }
9244     ; return 0; }
9245     EOF
9246     if { (eval echo configure:9247: \"$ac_compile\") 1>&5; (eval $ac_compile) 2>&5; }; then
9247       rm -rf conftest*
9248       ac_cv_have_uname_domainname_field=true

** CID 319786:  Null pointer dereferences  (REVERSE_INULL)
/tmp/sbbs-May-02-2021/3rdp/src/mozjs/js-1.8.5/js/src/configure: 9243 in main()


________________________________________________________________________________________________________
*** CID 319786:  Null pointer dereferences  (REVERSE_INULL)
/tmp/sbbs-May-02-2021/3rdp/src/mozjs/js-1.8.5/js/src/configure: 9243 in main()
9237       cat > conftest.$ac_ext <>>     CID 319786:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "res" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
9243                 (void)uname(res);  if (res != 0) { domain = res->domainname; }
9244     ; return 0; }
9245     EOF
9246     if { (eval echo configure:9247: \"$ac_compile\") 1>&5; (eval $ac_compile) 2>&5; }; then
9247       rm -rf conftest*
9248       ac_cv_have_uname_domainname_field=true


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DX3iR_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrC0xxJyxpTvK74OYpHBTr0bMvC0-2F55E9KXs2tam53Vd4fd9jUb9v2hpVvDivmVVFp4uIrtnyq5l1Wgm8kbqepynubswC56ZayoRnb9MlX-2FR3ROUHXxhLxY1pKgBRAQDFvXZnBNuFV30P7E152dPZ833OWNzH2elopnW-2BrlOv-2FcoDw-3D-3D


--- SBBSecho 3.14-Linux