Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

3 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 331003:  Error handling issues  (CHECKED_RETURN)
/js_internal.c: 1380 in js_handle_events()


________________________________________________________________________________________________________
*** CID 331003:  Error handling issues  (CHECKED_RETURN)
/js_internal.c: 1380 in js_handle_events()
1374     				if (input_locked)
1375     					js_do_lock_input(cx, FALSE);
1376     			}
1377     			if (ev->type == JS_EVENT_SOCKET_CONNECT) {
1378     				if ((jssp = (js_socket_private_t*)JS_GetPrivate(cx, ev->cx)) != NULL) {
1379     					slen = sizeof(jssp->remote_addr.addr);
>>>     CID 331003:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "getpeername(ev->data.connect.sock, __SOCKADDR_ARG({.__sockaddr__ = &jssp->remote_addr.addr}), &slen)" without checking return value. This library function may fail and return an error code.
1380     					getpeername(ev->data.connect.sock, &jssp->remote_addr.addr, &slen);
1381     				}
1382     			}
1383
1384     			ret = JS_CallFunction(cx, ev->cx, ev->cb, 0, NULL, &rval);
1385

** CID 319807:  Memory - illegal accesses  (UNINIT)
/tmp/sbbs-Apr-08-2021/3rdp/src/mozjs/js-1.8.5/js/src/configure: 9243 in main()


________________________________________________________________________________________________________
*** CID 319807:  Memory - illegal accesses  (UNINIT)
/tmp/sbbs-Apr-08-2021/3rdp/src/mozjs/js-1.8.5/js/src/configure: 9243 in main()
9237       cat > conftest.$ac_ext <>>     CID 319807:  Memory - illegal accesses  (UNINIT)
>>>     Using uninitialized value "res" when calling "uname".
9243                 (void)uname(res);  if (res != 0) { domain = res->domainname; }
9244     ; return 0; }
9245     EOF
9246     if { (eval echo configure:9247: \"$ac_compile\") 1>&5; (eval $ac_compile) 2>&5; }; then
9247       rm -rf conftest*
9248       ac_cv_have_uname_domainname_field=true

** CID 319786:  Null pointer dereferences  (REVERSE_INULL)
/tmp/sbbs-Apr-08-2021/3rdp/src/mozjs/js-1.8.5/js/src/configure: 9243 in main()


________________________________________________________________________________________________________
*** CID 319786:  Null pointer dereferences  (REVERSE_INULL)
/tmp/sbbs-Apr-08-2021/3rdp/src/mozjs/js-1.8.5/js/src/configure: 9243 in main()
9237       cat > conftest.$ac_ext <>>     CID 319786:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "res" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
9243                 (void)uname(res);  if (res != 0) { domain = res->domainname; }
9244     ; return 0; }
9245     EOF
9246     if { (eval echo configure:9247: \"$ac_compile\") 1>&5; (eval $ac_compile) 2>&5; }; then
9247       rm -rf conftest*
9248       ac_cv_have_uname_domainname_field=true


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp-2FP9gGRhvFklLaQKuBylUrkMFB3WMR2p7qIYKYTZrh4BbWTBf-2B-2Fi5ZUVF-2Fo-2B6flxo-3DP0xZ_g4j7BHlu96plUOfCQsO0yRjoWZCZl8YGnZ-2FUtT39hrDo6ivZGmytTAL00doqfqbfUsy6FdxkoNH-2Fs304jB2pO9-2BA5fDzAo7awTbWSo4epNb-2BDqywttda6gG5YgaK87Te0xpfQsBdPkHybxzL93bgAty0r9Blm4th52wVd-2Fmy5SlQory2xrpQK2iWC7fsB4fn9BTmkBhfI3JXMS1Pz2ZGO3UnM7DDlrLhhq6d9tkGVgg-3D


--- SBBSecho 3.14-Linux