On 2017 Jan 27 11:08:12, Rick Christian wrote to Jeff Smith:
yes, i know this is old and i'm top posting... sorry...
i've spent the last day hunting down this patch because my golded+ was crashing
with "stack smashing detected"... yeah, i was running my terminal window at max
screen size which is now 271x70... if i drop to 256x70, i can read but, as
noted below, the internal editor craps the sheets... dropping back to 255x70
allows both to work... i am NOT using the patch... it didn't seem to do any
good either way and i was still limited in max COLSxROWS... i even added a
second zero to make the buf larger and that didn't help, either... the problem
is the same with my old golded using the code from cvs and this new one using
the latest code from github... it is really starting to look like there's a
byte size counter somewhere that is the real problem... i hate that my C/C++
skills are non-existant these days :(
RC> I am too impatient to enlarge, start Golded, rinse, repeat to find the
RC> limit where things break...
RC> BUT
RC> On my 26-50" screens full screen terminals will break golded starting,
RC> period,
RC> THere is a patch:
RC> https://fidonet.ozzmosis.com/echomail.php/golded/37e10bdf0c33c539.html
RC> The patch below fixes a bug where a very wide terminal causes GoldED to
RC> crash:
RC> ---------- Fri 21 Nov 14, GoldED+/BSD 1.1.5-b20130910 (Nov 16 2014
RC> 22:19:02) ! 23:02:48 Memory error at [gemlst.cpp,365]. ! 23:02:48
RC> gsprintf(buffer,256,%-5.5s%s%-*.*s %-*.*s%s%-*.*s %s,...): buffer overflow
RC> (need 381 bytes).
RC> Index: gemlst.cpp
RC> ===================================================================
RC> RCS file: /cvsroot/golded-plus/golded+/golded3/gemlst.cpp,v
RC> retrieving revision 1.67
RC> diff -u -r1.67 gemlst.cpp
RC> -+- gemlst.cpp 19 Oct 2011 23:31:31 -0000 1.67
RC> +++ gemlst.cpp 22 Nov 2014 16:50:45 -0000
RC> {at}{at} -333,7 +333,7 {at}{at}
RC> mattr_ = hattr;
RC> }
RC> - char buf[256];
RC> + char buf[2560];
RC> if(AA->Msglistwidesubj()) {
RC> resiz += tosiz + 1;
RC> Which does let wide terminals work... I've done it to all the ones of
RC> recent... and works.
RC> BUT
RC> ONLY FOR READING
RC> If you reply the internal editor barfs and seg faults... for probably
RC> similar reasons... but I just don't have time to dig through to find its
RC> buffer to enlarge it.
)\/(ark
Always Mount a Scratch Monkey
Do you manage your own servers? If you are not running an IDS/IPS yer doin' it
wrong...
... When I spilled my cottage cheese, I lost my whey.
---
* Origin: (1:3634/12.73)
|