TIP: Click on subject to list as thread! ANSI
echo: makenl_ng
to: Wilfred van Velzen
from: Andrew Leary
date: 2016-12-02 10:24:22
subject: MakeNL 3.4.6 Release

Hello Wilfred!

02 Dec 16 13:11, you wrote to me:

 WV> Your using strcpy to copy overlapping strings. The behaviour of strcpy
 WV> when source and destination overlap is undefined for all definitions
 WV> of strcpy I know. So it might work, or it might not, for all
 WV> permutations of compilers, os's and compiler options, that makenl is
 WV> compiled on.

 WV> I suggest:

 WV>                  memmove(templine, templn2, strlen(templn2) + 1);

 WV> The same is true for the fts5.c file, with about the same code...

Good point.  I will make that change today.  The released files do work, as 
the compilers used (OpenWatcom 1.9 and gcc 5.3.0) apparently do the copy left 
to right, so the source isn't overwritten until after it has been read and 
copied to the destination.  For portability purposes, it should be fixed.

Thanks for the report.

Andrew

--- GoldED+/LNX 1.1.5-b20160322
* Origin: Phoenix BBS * phoenix.bnbbbs.net (1:320/219)
SEEN-BY: 3/50 154/10 203/0 221/1 227/51 230/0 240/5832 249/303 261/38 266/404
SEEN-BY: 280/464 5003 5555 292/624 854 320/119 219 340/200 423/120 633/267 280
SEEN-BY: 640/384 712/620 848 770/1 2320/100
@PATH: 320/219 203/0 280/464 712/848 633/267

SOURCE: echomail via fidonet.ozzmosis.com

Email questions or comments to sysop@ipingthereforeiam.com
All parts of this website painstakingly hand-crafted in the U.S.A.!
IPTIA BBS/MUD/Terminal/Game Server List, © 2025 IPTIA Consulting™.