JT>   fread (
 JT>       s[r[i]->target].typeid,
 JT>       sizeof (short int), 1, f );

 JT> Would this be a better idea:

 JT>   fread (
 JT>       s[r[i]->target].typeid,
 JT>       sizeof (short int), 1, f
 JT>   );

IMNSHO, both are somewhat unreadable.  :-)

fread(
      s[r[i]->target].typeid, /* can't we clean this one up? */
      sizeof(short int),      /* short int is the same as just short */
      1,
      f
     );

Well, that's better, but...

const size_t read_target = r[i]->target;
const short* p_typeid    = s[read_target].typeid;
fread(p_typeid, sizeof(*p_typeid), 1, f);

That I find to be much improved.  Just my opinion, of course.


---