>> fread (
>>   s[r[i]->target].typeid,
>>   sizeof (short int), 1, f
>> );
> IMNSHO, both are somewhat unreadable.  :-)

Yes. That is a bit tricky.

> fread(
>   s[r[i]->target].typeid, /* can't we clean this one up? */
>   sizeof(short int),      /* short int is the same as just short */
>   1,
>   f
> );
> Well, that's better, but...

This makes it easily pretty long. But it sure is a lot cleaner. At least
with Windows it's better. I hate long function calls.

> const size_t read_target = r[i]->target;
> const short* p_typeid    = s[read_target].typeid;
> fread(p_typeid, sizeof(*p_typeid), 1, f);

> That I find to be much improved.  Just my opinion, of
> course.

That might be worth considering. But it looks a bit messy since there is so
much code to simplify one function call. On the other hand I use lot's of
similar fread()s on the project that the sample was taken from.

... All you need is love.

--- BBBS/LiI v3.42 ToMmIk-3v