> const size_t read_target = r[i]->target;
> const short* p_typeid    = s[read_target].typeid;
> fread(p_typeid, sizeof(*p_typeid), 1, f);

> That I find to be much improved.  Just my opinion, of
> course.

 JT> That might be worth considering. But it looks a bit 
 JT> messy since there is so much code to simplify one 
 JT> function call. On the other hand I use lot's of similar 
 JT> fread()s on the project that the sample was taken from.

Sometimes simpler code is shorter, sometimes it is longer.  Interestingly,
the above code should be optimizable into the original code, meaning it
should be just as fast, and just as short (codesize).  So it isn't really
longer to the CPU during runtime.  (Not that this should matter too much -
you're doing file I/O which is inherently slower than the memory tricks you
do to generate the first parameter...)


---